-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add makeNonTrivial
helper in Search
#5092
base: master
Are you sure you want to change the base?
Add makeNonTrivial
helper in Search
#5092
Conversation
b16785b
to
22e8f70
Compare
22e8f70
to
02cc64f
Compare
51f569b
to
af3e1ab
Compare
Candidate for squash-merge if accepted |
Ping |
I don't quite get the name makeNonTrivial? |
Ah, yeah, I couldn't think of a shorter name. Returning the same point as result of search is basically a trivial answer. Ofc the point from the cloud is going to be in there. Maybe I overthought? 😅 |
Instead of modifying multiple call sites with what looks like really weird code, I think it's better to instead add a helper and test it properly.
Related PR: #5051 #5057