Fix: handle geometry in get one export api method #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouttier
approved these changes
Sep 27, 2024
|
OK merci, une raison pour laquelle les tests Python ne passent pas ? |
|
Oups il y a pas l’air d’avoir l’autorisation aux mainteneurs de modifier la branche sur cette PR, du coup j’ai ouvert une autre PR là pour débugger : #216 |
|
@bouttier J'ai intégré les modif ta PR dans cette branche. Comme ça on a le dev et les tests en même temps ! |
jacquesfize
pushed a commit
that referenced
this pull request
Oct 4, 2024
* fix: handle geometry in get_one_export_api method * tests: output response content on assertion error * test: adjust test to geojson format --------- Co-authored-by: Élie Bouttier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #214
L'issue est assez détaillée, et renvoi à un argumentaire, également détaillé, dans issue+PR dans le projet Utils-Flask-SQLAlchemy-Geo.