Skip to content

Commit

Permalink
Merge branch 'release/0.3.0'
Browse files Browse the repository at this point in the history
  • Loading branch information
sgrimault committed Mar 1, 2020
2 parents 48ade07 + 950a901 commit 5441bda
Show file tree
Hide file tree
Showing 15 changed files with 65 additions and 38 deletions.
1 change: 0 additions & 1 deletion .idea/codeStyles/Project.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion .idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.5.3'
classpath 'com.android.tools.build:gradle:3.6.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "org.jlleitschuh.gradle:ktlint-gradle:9.1.1"
// NOTE: Do not place application dependencies here; they belong
Expand Down
2 changes: 1 addition & 1 deletion gn_mobile_core
Submodule gn_mobile_core updated 28 files
+0 −4 .idea/codeStyles/Project.xml
+3 −1 .idea/gradle.xml
+1 −1 build.gradle
+2 −2 commons/build.gradle
+14 −4 commons/src/main/java/fr/geonature/commons/data/AbstractTaxon.kt
+36 −16 commons/src/test/java/fr/geonature/commons/data/TaxonTest.kt
+3 −1 gradle.properties
+2 −2 gradle/wrapper/gradle-wrapper.properties
+11 −4 sync/README.md
+7 −7 sync/build.gradle
+5 −4 sync/src/debug/AndroidManifest.xml
+0 −6 sync/src/debug/res/xml/network_security_config.xml
+5 −5 sync/src/main/java/fr/geonature/sync/api/GeoNatureAPIClient.kt
+5 −2 sync/src/main/java/fr/geonature/sync/api/GeoNatureService.kt
+6 −2 sync/src/main/java/fr/geonature/sync/api/TaxHubService.kt
+3 −0 sync/src/main/java/fr/geonature/sync/api/model/Taxref.kt
+10 −2 sync/src/main/java/fr/geonature/sync/settings/AppSettings.kt
+2 −0 sync/src/main/java/fr/geonature/sync/settings/io/OnAppSettingsJsonReaderListenerImpl.kt
+12 −2 sync/src/main/java/fr/geonature/sync/sync/DataSyncViewModel.kt
+25 −7 sync/src/main/java/fr/geonature/sync/sync/DataSyncWorker.kt
+120 −95 sync/src/main/java/fr/geonature/sync/ui/home/HomeActivity.kt
+36 −33 sync/src/main/java/fr/geonature/sync/ui/login/LoginActivity.kt
+24 −0 sync/src/main/java/fr/geonature/sync/util/LiveDataUtils.kt
+10 −2 sync/src/test/java/fr/geonature/sync/settings/io/OnAppSettingsJsonReaderListenerImplTest.kt
+3 −1 sync/src/test/resources/fixtures/settings_sync.json
+2 −2 sync/version.properties
+1 −1 viewpager/build.gradle
+2 −0 viewpager/src/main/res/layout/activity_pager.xml
4 changes: 4 additions & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
android.enableJetifier=true
android.useAndroidX=true
kotlin.code.style=official
android.enableUnitTestBinaryResources=true
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Wed Aug 21 20:56:36 CEST 2019
#Wed Feb 26 21:54:13 CET 2020
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip
2 changes: 1 addition & 1 deletion occtax/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'

version = "0.2.9"
version = "0.3.0"

android {
compileSdkVersion 28
Expand Down
3 changes: 2 additions & 1 deletion occtax/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
android:theme="@style/AppTheme.NoActionBar" />
<activity
android:name=".ui.input.InputPagerFragmentActivity"
android:screenOrientation="portrait" />
android:screenOrientation="portrait"
tools:ignore="LockedOrientationActivity" />
<activity
android:name=".ui.input.taxa.TaxonomyFilterActivity"
android:label="@string/activity_taxonomy_title" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,16 @@ class TaxaFragment : Fragment(),
)

val taxonFilter =
Taxon.Filter().byName(args?.getString(KEY_FILTER_BY_NAME)).also {
val filterByTaxonomy = args?.getParcelable<Taxonomy>(
KEY_FILTER_BY_TAXONOMY
)
Taxon.Filter().byNameOrDescription(args?.getString(KEY_FILTER_BY_NAME))
.also {
val filterByTaxonomy = args?.getParcelable<Taxonomy>(
KEY_FILTER_BY_TAXONOMY
)

if (filterByTaxonomy != null) {
(it as Taxon.Filter).byTaxonomy(filterByTaxonomy)
}
}.build()
if (filterByTaxonomy != null) {
(it as Taxon.Filter).byTaxonomy(filterByTaxonomy)
}
}.build()

CursorLoader(
requireContext(),
Expand Down Expand Up @@ -190,7 +191,7 @@ class TaxaFragment : Fragment(),
}

override fun scrollToFirstSelectedItemPosition(position: Int) {
recyclerView.smoothScrollToPosition(position)
recyclerView.scrollToPosition(position)
}

override fun showEmptyTextView(show: Boolean) {
Expand Down Expand Up @@ -303,7 +304,10 @@ class TaxaFragment : Fragment(),
}

override fun onQueryTextChange(newText: String): Boolean {
savedState.putString(KEY_FILTER_BY_NAME, newText)
savedState.putString(
KEY_FILTER_BY_NAME,
newText
)
loadTaxa()

return true
Expand All @@ -317,10 +321,12 @@ class TaxaFragment : Fragment(),
val context = context ?: return true
startActivityForResult(
TaxonomyFilterActivity.newIntent(
context, savedState.getParcelable(
context,
savedState.getParcelable(
KEY_FILTER_BY_TAXONOMY
)
), RESULT_FILTER
),
RESULT_FILTER
)
true
}
Expand Down Expand Up @@ -372,7 +378,10 @@ class TaxaFragment : Fragment(),

override fun setInput(input: AbstractInput) {
this.input = input as Input
savedState.putString(KEY_SELECTED_FEATURE_ID, input.selectedFeatureId)
savedState.putString(
KEY_SELECTED_FEATURE_ID,
input.selectedFeatureId
)
}

private fun loadTaxa() {
Expand Down Expand Up @@ -413,7 +422,8 @@ class TaxaFragment : Fragment(),
if (filterChipGroup.childCount > 0) View.VISIBLE else View.GONE

if (selectedTaxonomy == null) savedState.remove(KEY_FILTER_BY_TAXONOMY) else savedState.putParcelable(
KEY_FILTER_BY_TAXONOMY, selectedTaxonomy
KEY_FILTER_BY_TAXONOMY,
selectedTaxonomy
)

if (selectedTaxonomy != null) {
Expand All @@ -436,7 +446,10 @@ class TaxaFragment : Fragment(),
filterByTaxonomy(null)
}

filterChipGroup.addView(this, taxonomyChipIndex)
filterChipGroup.addView(
this,
taxonomyChipIndex
)
}

// build group taxonomy filter chip
Expand All @@ -457,7 +470,10 @@ class TaxaFragment : Fragment(),
filterByTaxonomy(Taxonomy((it.tag as Taxonomy).kingdom))
}

filterChipGroup.addView(this, taxonomyChipIndex + 1)
filterChipGroup.addView(
this,
taxonomyChipIndex + 1
)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import android.view.View
import android.view.ViewGroup
import android.widget.CheckBox
import android.widget.TextView
import androidx.core.text.HtmlCompat
import androidx.recyclerview.widget.RecyclerView
import com.l4digital.fastscroll.FastScroller
import fr.geonature.commons.data.AbstractTaxon
Expand Down Expand Up @@ -207,7 +208,10 @@ class TaxaRecyclerViewAdapter(private val listener: OnTaxaRecyclerViewAdapterLis
.toString()
title.text = if (previousTitle == currentTitle) "" else currentTitle
text1.text = taxon.name
text2.text = taxon.description
text2.text = HtmlCompat.fromHtml(
taxon.description ?: "",
HtmlCompat.FROM_HTML_MODE_COMPACT
)
checkbox.isChecked = selectedTaxon?.id == taxon.id

taxon.taxonArea?.run {
Expand Down
2 changes: 1 addition & 1 deletion occtax/src/main/res/layout/chip.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:textAppearance="@style/TextAppearance.MaterialComponents.Chip"
android:textColor="?android:attr/textColorPrimaryInverse"
android:theme="@style/Theme.MaterialComponents.Light"
app:chipBackgroundColor="@color/accent"
app:closeIconEnabled="true"
app:closeIconTint="?android:attr/textColorPrimaryInverse"
Expand Down
7 changes: 4 additions & 3 deletions occtax/src/main/res/layout/fragment_home.xml
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,12 @@
android:layout_gravity="bottom|end"
android:layout_marginEnd="@dimen/padding_default"
android:layout_marginBottom="@dimen/padding_default"
android:backgroundTint="@color/accent"
android:clickable="true"
android:focusable="true"
android:tint="@android:color/white"
android:visibility="invisible"
android:visibility="visible"
app:elevation="@dimen/fab_elevation"
app:srcCompat="@drawable/ic_add" />
app:srcCompat="@drawable/ic_add"
app:tint="@android:color/white" />

</androidx.coordinatorlayout.widget.CoordinatorLayout>
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<androidx.cardview.widget.CardView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginEnd="@dimen/padding_default"
android:layout_marginStart="@dimen/padding_default"
android:layout_marginTop="@dimen/padding_default"
android:layout_marginEnd="@dimen/padding_default"
app:cardCornerRadius="@dimen/cardview_radius"
app:cardElevation="@dimen/cardview_elevation"
app:contentPadding="@dimen/padding_default">
Expand All @@ -36,9 +36,9 @@
<androidx.cardview.widget.CardView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginEnd="@dimen/padding_default"
android:layout_marginStart="@dimen/padding_default"
android:layout_marginTop="@dimen/padding_default"
android:layout_marginEnd="@dimen/padding_default"
app:cardCornerRadius="@dimen/cardview_radius"
app:cardElevation="@dimen/cardview_elevation"
app:contentPadding="@dimen/padding_default">
Expand All @@ -56,9 +56,7 @@
<androidx.cardview.widget.CardView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginEnd="@dimen/padding_default"
android:layout_marginStart="@dimen/padding_default"
android:layout_marginTop="@dimen/padding_default"
android:layout_margin="@dimen/padding_default"
app:cardCornerRadius="@dimen/cardview_radius"
app:cardElevation="@dimen/cardview_elevation"
app:contentPadding="@dimen/padding_default">
Expand Down
6 changes: 4 additions & 2 deletions occtax/src/main/res/layout/list_item_taxon.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
android:id="@android:id/text1"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginEnd="?attr/listPreferredItemPaddingEnd"
android:layout_marginStart="?attr/listPreferredItemHeight"
android:layout_marginEnd="?attr/listPreferredItemPaddingEnd"
android:ellipsize="end"
android:maxLines="1"
android:textAppearance="?attr/textAppearanceListItem"
Expand All @@ -53,8 +53,10 @@
android:id="@android:id/text2"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginEnd="?attr/listPreferredItemPaddingEnd"
android:layout_marginStart="?attr/listPreferredItemHeight"
android:layout_marginEnd="?attr/listPreferredItemPaddingEnd"
android:ellipsize="end"
android:maxLines="1"
android:textAppearance="?attr/textAppearanceListItemSecondary"
app:layout_constraintEnd_toStartOf="@+id/taxon_last_updated_at_view"
app:layout_constraintStart_toStartOf="parent"
Expand Down
4 changes: 2 additions & 2 deletions occtax/version.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#Tue Feb 11 20:38:22 CET 2020
VERSION_CODE=1620
#Sun Mar 01 18:10:33 CET 2020
VERSION_CODE=1660

0 comments on commit 5441bda

Please sign in to comment.