Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and specs #3

Merged
merged 13 commits into from
Jun 26, 2024
Merged

Linting and specs #3

merged 13 commits into from
Jun 26, 2024

Conversation

HHassig
Copy link
Contributor

@HHassig HHassig commented Jun 24, 2024

This should be a much cleaner and organized version of the other branch. I left the other branch for reference, can be deleted.
Only think (i believe) left to do is "Lint ruby files" https://github.com/Platoniq/decidim-b4m/commit/6fbc9c165a2160deef5d2cf59e3de30f1ca9d1e7

@HHassig HHassig requested a review from fblupi June 24, 2024 19:26
Copy link

gitguardian bot commented Jun 24, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9774313 Triggered Generic Password 4978774 .github/workflows/test.yml View secret
9774313 Triggered Generic Password 4978774 .github/workflows/test.yml View secret
9774313 Triggered Generic Password 4978774 .github/workflows/test.yml View secret
9774313 Triggered Generic Password 4978774 .github/workflows/test.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, run: bundle exec rubocop -A to autocorrect all the files with rubocop and check with bundle exec rubocop -P if you need to correct something manually and do it too.

There is an error in the test CI. Please check it too. It seems the repo doesn't have a schema.rb file

@HHassig
Copy link
Contributor Author

HHassig commented Jun 26, 2024

I believe this is finally ready

@fblupi fblupi self-requested a review June 26, 2024 14:56
@fblupi fblupi merged commit 3044ff6 into initial_decidim Jun 26, 2024
3 checks passed
@fblupi fblupi deleted the linting_and_specs branch June 26, 2024 14:57
fblupi added a commit that referenced this pull request Jul 1, 2024
* initial commit

* add figaro

* add passsenger

* Linting and specs (#3)

* Added .github/workflow file for CI

* Lint ERB files with erblint

* Lint SCSS files with stylelint

* Add i18n spec

* Lint JS files with eslint

* Lint MarkDown files with mdl

* Default local to :ca

* Rubocop automatic fixes

* db:migrate to create db/schema.rb

* Revert "Default local to :ca"

This reverts commit 00532b0.

* Run Rubocop

* Rubocop corrections

* Restored db/migrate files to before rubocop fixes

* Remove config/deploy symlink and fix .gitignore

* Initial cleanup (#4)

* Add GH CI result to README.md

* Ignore .rspec-failures

* i18n spec file

* homepage and other spec files

* Remove test directory

* Fix README rubocop suggestion

* i18n_spec to english

* default locale to :ca, edit en.yml

* Platoniq and EU logos in footer

* More spec files to go with the new footer

* Edited expected checksum in overrides_spec.rb

* remove eu logo

* public.sw.js* in .gitignor

* Remove cached ublic/sw.js* files

* correct platoniq footer spec

* Remove lingering EU footer files

* default locale to :en to be overwritten with env variable

* Add decidim awesome (#5)

* Add GH CI result to README.md

* Ignore .rspec-failures

* i18n spec file

* homepage and other spec files

* Remove test directory

* Fix README rubocop suggestion

* i18n_spec to english

* default locale to :ca, edit en.yml

* Platoniq and EU logos in footer

* More spec files to go with the new footer

* Edited expected checksum in overrides_spec.rb

* Add decidim awesome

* db:migrate for rspec failing

* add decidim awesome to gemfile and run webpack install for decidim awesome

* decidim_awesome spec file

* update decidim dev packages to correct version

* remove eu-logo.png

* default locale to :en

* remove eu.en.yml

* Remove cached public/sw.js* files

* remove eu_footer_spec.rb

* Add decidim awesome factories

---------

Co-authored-by: Fran Bolívar <[email protected]>

* Update README.md

* Move .erb-lint.yml

---------

Co-authored-by: David Igón <[email protected]>
Co-authored-by: Harrison Hassig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants