Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GH CI. #43

Draft
wants to merge 14 commits into
base: release-1.0
Choose a base branch
from
Draft

Conversation

InukVT
Copy link
Contributor

@InukVT InukVT commented Feb 19, 2020

This CI is build to make automated TestFlight builds in the neat future.

@InukVT InukVT changed the base branch from master to release-1.0 February 19, 2020 09:19
@adilanchian
Copy link
Collaborator

This will become more useful when we have tests to gate our merge and when we have a beta which we could push new builds to TestFlight with.

ALSO - This process may be slightly different for React Native... @BastianInuk can you see if this process would still fly with React Native?

@InukVT
Copy link
Contributor Author

InukVT commented Feb 19, 2020

This one is made for React Native iOS, and can be modified for an Android version with relatice ease

@adilanchian
Copy link
Collaborator

@BastianInuk okay sweet! So it seems like the main steps needed for this thing are:

  1. Get tests setup for this
  2. Get an Android build process setup as well
  3. Get TestFlight handled

Thoughts?

@InukVT
Copy link
Contributor Author

InukVT commented Feb 20, 2020 via email

@adilanchian
Copy link
Collaborator

Yes I do not expect you to write any tests for this PR. Cool with the other two points as well. This is still a tad far off. Once we get closer we can actually get this implemented.

@InukVT
Copy link
Contributor Author

InukVT commented Feb 20, 2020

@julienroulle
Copy link

Maybe this one?

https://github.com/BastianInuk/Gruvee/blob/master/ios/Gruvee.xcodeproj/xcshareddata/xcschemes/Gruvee.xcscheme

@InukVT
Copy link
Contributor Author

InukVT commented Feb 21, 2020

Thus far, thus good, now I just need a development profile:
https://github.com/BastianInuk/Gruvee/runs/459671339?check_suite_focus=true#step:5:8

@adilanchian
Copy link
Collaborator

Hey I have not yet - but will follow up on this at some point this weekend. Thanks!

@adilanchian
Copy link
Collaborator

Going to keep this on hold until we can utilize this is a proper way:
ie: when we have betas ready to go

@InukVT
Copy link
Contributor Author

InukVT commented Mar 12, 2020

@adilanchian I think you should set up the fastlane on your personal desktop, and hide away your creds in the GitHub secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants