Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring HarDNet for readability #6

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

joeltio
Copy link

@joeltio joeltio commented May 21, 2020

Hi,
I would like to work on making the HarDNet code more readable so that others can understand and adapt it more easily.

I have started working on some simple things to improve the code such as error handling for unsupported architectures or clearing trailing whitespace.

Currently I have these things in mind:

  • Updating get_links to be more concise and also generalise to more than 1024 layers (because of this
  • More comments to explain what is going on and where the implementation was mentioned in the paper
  • Update loading of model to support cpu-based models (this part needs a map_location=torch.device("cpu") for cpu-based models to work)
  • General readability of other parts of the code

Please let me know if there's any part you might also want me to look at or if there's something you would like to keep.

@PingoLH
Copy link
Owner

PingoLH commented Aug 3, 2020

Hi, Thank you so much for your contribution and so sorry for the late reply. Please let me know if your change is ready to merge and I will merge it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants