WIP cube

PilotLightTech · Jan 18, 2025 · 1d4acf4 · 1d4acf4
1 parent c1c2b84
commit 1d4acf4
Show file tree

Hide file tree

Showing 5 changed files with 141 additions and 165 deletions.
diff --git a/extensions/pl_graphics_ext.h b/extensions/pl_graphics_ext.h
@@ -464,6 +464,7 @@ typedef struct _plTextureViewDesc
     uint32_t        uBaseLayer;
     uint32_t        uLayerCount;
     plTextureHandle tTexture;
+    plTextureType   tType;
     const char*     pcDebugName; // default: "unnamed texture view"
 } plTextureViewDesc;
 

diff --git a/extensions/pl_graphics_metal.m b/extensions/pl_graphics_metal.m
@@ -1054,6 +1054,7 @@
     ptNewTexture->tView = *ptViewDesc;
     ptNewTexture->tDesc.uMips = ptViewDesc->uMips;
     ptNewTexture->tDesc.uLayers = ptViewDesc->uLayerCount;
+    ptNewTexture->tDesc.tType = ptViewDesc->tType;
     ptNewTexture->tView.uBaseMip = 0;
     ptNewTexture->tView.uBaseLayer = 0;
 

diff --git a/extensions/pl_graphics_vulkan.c b/extensions/pl_graphics_vulkan.c
@@ -1265,18 +1265,19 @@ pl_create_texture_view(plDevice* ptDevice, const plTextureViewDesc* ptViewDesc)
     plTexture* ptOriginalTexture = pl__get_texture(ptDevice, ptViewDesc->tTexture);
     plTexture* ptNewTexture = pl__get_texture(ptDevice, ptViewDesc->tTexture);
     ptNewTexture->tDesc = ptOriginalTexture->tDesc;
+    ptNewTexture->tDesc.tType = ptViewDesc->tType;
     ptNewTexture->tView = *ptViewDesc;
     plVulkanTexture* ptOldVulkanTexture = &ptDevice->sbtTexturesHot[ptViewDesc->tTexture.uIndex];
     plVulkanTexture* ptNewVulkanTexture = &ptDevice->sbtTexturesHot[tHandle.uIndex];
 
     //~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~create view~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
     VkImageViewType tImageViewType = 0;
-    if (ptOriginalTexture->tDesc.tType == PL_TEXTURE_TYPE_CUBE)
+    if (ptNewTexture->tDesc.tType == PL_TEXTURE_TYPE_CUBE)
         tImageViewType = VK_IMAGE_VIEW_TYPE_CUBE;
-    else if (ptOriginalTexture->tDesc.tType == PL_TEXTURE_TYPE_2D)
+    else if (ptNewTexture->tDesc.tType == PL_TEXTURE_TYPE_2D)
         tImageViewType = VK_IMAGE_VIEW_TYPE_2D;
-    else if (ptOriginalTexture->tDesc.tType == PL_TEXTURE_TYPE_2D_ARRAY)
+    else if (ptNewTexture->tDesc.tType == PL_TEXTURE_TYPE_2D_ARRAY)
         tImageViewType = VK_IMAGE_VIEW_TYPE_2D; // VK_IMAGE_VIEW_TYPE_2D_ARRAY;
     else
     {
@@ -4329,7 +4330,7 @@ pl__fill_common_render_pass_data(plRenderPassLayoutDesc* ptDesc, plRenderPassLay
         .dstStageMask    = VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT,
         .srcAccessMask   = VK_ACCESS_SHADER_WRITE_BIT | VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT,
         .dstAccessMask   = VK_ACCESS_SHADER_READ_BIT | VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT,
-        .dependencyFlags = 0
+        .dependencyFlags = VK_DEPENDENCY_BY_REGION_BIT
     };
 
     ptDataOut->atSubpassDependencies[1] = (VkSubpassDependency){