Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve install files in CMake #14

Open
wants to merge 2 commits into
base: kinetic-devel
Choose a base branch
from
Open

Improve install files in CMake #14

wants to merge 2 commits into from

Conversation

davetcoleman
Copy link
Member

@davetcoleman davetcoleman commented Jul 28, 2017 •
edited
Loading

@enricotoi please review

closes #13 and #11

@davetcoleman davetcoleman mentioned this pull request Jul 28, 2017
Open
AndyZe
AndyZe reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@AndyZe AndyZe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a commit to clean up some unneeded files. Haven't tested yet (got distracted).

CMakeLists.txt Outdated

# Mark config files for installation
install(FILES
config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder doesn't exist, so this line causes a build error. Delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyZe AndyZe AndyZe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davetcoleman @AndyZe