Skip to content

Commit

Permalink
Remove incorrect override of tip_frames (#68)
Browse files Browse the repository at this point in the history
  • Loading branch information
amalnanavati authored Sep 30, 2024
1 parent 87b4c60 commit 5b6dffc
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions src/pick_ik_plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,6 @@ class PickIKPlugin : public kinematics::KinematicsBase {
}
}

// If jmg has tip frames, set tip_frames_ to jmg tip frames
// consider removing these lines as they might be unnecessary
// as tip_frames_ is set by the call to storeValues above
auto jmg_tips = std::vector<std::string>{};
jmg_->getEndEffectorTips(jmg_tips);
if (!jmg_tips.empty()) tip_frames_ = jmg_tips;

// link_names are the same as tip frames
// TODO: why do we need to set this
link_names_ = tip_frames_;
Expand Down

0 comments on commit 5b6dffc

Please sign in to comment.