[Dehardcode] Bunkerable dehardcode

[TaranDahl]

skip the hardcoded checks to static properties

[github-actions]

Nightly build for this pull request:

• compiled-dll-1707ff5338c193261b5ab9561d8896d234132fbe.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Metadorius]

I think a better way to implement that would be making Bunkerable=yes work on the combinations that are proven to be not causing major issues.

[TaranDahl]

I think a better way to implement that would be making Bunkerable=yes work on the combinations that are proven to be not causing major issues.

What does “combination” mean 🤔 I don't quite understand you

[Metadorius]

What does “combination” mean 🤔 I don't quite understand you

In your doc you said:

Skipping checks with this feature doesn't mean that vehicles and tank bunkers will interact correctly.

What I mean is that it's better to try different things on vehicles, like hover locomotor or anything that prevented Bunkerable=yes from working before, and if it's working correctly - then allow it, if it is bugged - then don't allow bunkering regardless.

[TaranDahl]

What I mean is that it's better to try different things on vehicles, like hover locomotor or anything that prevented Bunkerable=yes from working before, and if it's working correctly - then allow it, if it is bugged - then don't allow bunkering regardless.

The original three checks in this function were no turret/no weapon/speed type is Hover. It is certain that they are all unreasonable.
I can test all the locos available to the vehicle and rule out the ones that don't work at all, but I don't know if there are any other flags besides loco that would invalidate the entry.
There are also some flags that can cause weird results. For example, a vehicle without a turret will rotate its body to target the enemy after entering; a vehicle with tunnel loco will enter the bunkered state in the incorrect position. I think these results should not be simply classified as bugs, maybe someone wants to use them. That's why I said in the documentation that it doesn't "interact correctly".

[TaranDahl]

I tried all loco. It looks like fly mech and hover can't get into the tank bunker.

[MortonPL]

I think that this change could be permanently enabled. Why does it need to be explicitly enabled? It won't affect vehicles that don't have Bunkerable=yes set anyway and it doesn't involve any costly logic.

[Aephiex]

I think that this change could be permanently enabled. Why does it need to be explicitly enabled? It won't affect vehicles that don't have Bunkerable=yes set anyway and it doesn't involve any costly logic.

If you mean Phobos will permanently change how bunkerability is checked, leaving no room for customization, despite that sounds like a blasphemy there isn't really any harm in it.

[TaranDahl]

I think that this change could be permanently enabled. Why does it need to be explicitly enabled? It won't affect vehicles that don't have Bunkerable=yes set anyway and it doesn't involve any costly logic.

According to ModEnc, the default value of Bunkerable is yes. If enabled permanently, it will change the default🤔

[Aephiex]

According to ModEnc, the default value of Bunkerable is yes. If enabled permanently, it will change the default🤔

Ah, shikataganai. In that case there has to be a toggle for BunkerableAnyway.

[Aephiex]

I have a suggestion, to list in the docs all hardcoded checks for bunkerability and to tell which can be bypassed by BunkerableAnyway=yes and which can't be bypassed by it.