Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thousand separator options #12

Merged
merged 18 commits into from
Oct 9, 2024
Merged

Add thousand separator options #12

merged 18 commits into from
Oct 9, 2024

Conversation

PgBiel
Copy link
Owner

@PgBiel PgBiel commented Oct 1, 2024

Closes #5

Also some UTF-8 padding bugs and some float edge cases (more in a future PR).

Options:

  1. fmt-thousands-separator: "_" => displays _ every fmt-thousands-count digits
    • Defaults to "" which disables it
  2. fmt-thousands-count: 2 => changes amount of digits per thousand (determines how often to place the separator)
    • Defaults to 3
    • Must be positive (please disable the separator, not the count)

@PgBiel PgBiel marked this pull request as ready for review October 9, 2024 02:49
@PgBiel PgBiel merged commit d660b11 into main Oct 9, 2024
7 checks passed
@PgBiel PgBiel deleted the thousand-sep branch October 9, 2024 02:50
@PgBiel PgBiel added this to the 1.0.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: digit grouping (thousands separator)
1 participant