Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to allow for looking up an IP address #21

Closed
wants to merge 2 commits into from

Conversation

mitchellkellett
Copy link

@mitchellkellett mitchellkellett commented Mar 10, 2023

Addresses issue #20.

Added functionality to allow for looking up an IP address by using NGINX maps.
- New map.conf that containing maps.
- Updated nginx.conf to increase map_hash_bucket_size above default value.
- Updated geoip2.conf to include new variables for lookup IP addresses.
- Updated ipinfo.conf to include new location blocks to allow for looking up IP addresses.
Moved existing functionality for looking up requesting IP address to use NGINX maps.
- Updated ipinfo.conf to remove old location blocks that have been moved to map.conf.
Updated README to include details on added functionality.

…INX maps.

	- New map.conf that containing maps.
	- Updated nginx.conf to increase map_hash_bucket_size above default value.
	- Updated geoip2.conf to include new variables for lookup IP addresses.
	- Updated ipinfo.conf to include new location blocks to allow for looking up IP addresses.
Moved existing functionality for looking up requesting IP address to use NGINX maps.
	- Updated ipinfo.conf to remove old location blocks that have been moved to map.conf.
Updated README to include details on added functionality.
Copy link
Owner

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, as the change is huge, I'll take more time to take a look at it.

@mitchellkellett
Copy link
Author

mitchellkellett commented Mar 10, 2023

I've just found some bugs in it. I'm working to fix them. It's mostly the regex that I thought I had right, but didn't.

Added build data to headers.
Formatting updated throughout.
Updated regex to fix identified bug in map.conf.
@mitchellkellett
Copy link
Author

Should be fixed now.

Copy link
Owner

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitchellkellett thanks for your help. I noticed that you also added/changed the function to show more details info like city. Can we separate that part in another pull request, and focus on the functionality to allow looking up a certain IP address? Thanks.

@PeterDaveHello
Copy link
Owner

Hi @mitchellkellett, would you like to continue this pull request ;)

@mitchellkellett
Copy link
Author

mitchellkellett commented Apr 10, 2023

Hi @mitchellkellett, would you like to continue this pull request ;)

Sorry, I'll update this PR, just haven't had a chance to get to it yet.

Will raise two new PRs for the new functionality.

@PeterDaveHello
Copy link
Owner

Thank you very much, looking forward to have your PR then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants