ENH: Update eddy_params.json #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for eddy is flm: quadratic, slm: none. For modern data, flm: linear is not enough correction. The second level model is recommended for older and lower resolution data.
|
Full disclosure, flm: quadratic / slm: linear is what I use, so here's my pitch. @mattcieslak I know you mentioned using quadratic / quadratic but I looked through the FSL list and could not find any posts from the FMRIB group using anything other than linear for slm. It might not make a big difference, but I figure it would be good for the defaults to follow the advice on the eddy user guide and mailing list, just so people don't worry about the difference. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 44.23% 44.23%
=======================================
Files 66 66
Lines 9839 9839
Branches 1097 1097
=======================================
Hits 4352 4352
Misses 5263 5263
Partials 224 224 ☔ View full report in Codecov by Sentry. |
mattcieslak
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Change the default eddy flm from linear to quadratic. This matches the eddy default.
The slm remains linear, as recommended for lower-resolution data.
Documentation that should be reviewed
I don't think the defaults are mentioned in the docs.