Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter jobs #118

Merged
merged 17 commits into from
May 25, 2024
Merged

Filter jobs #118

merged 17 commits into from
May 25, 2024

Conversation

dhruv8433
Copy link
Contributor

@dhruv8433 dhruv8433 commented May 21, 2024

@PatilHarshh

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]

BUG: Filter Not Working #72

close #72

Description

[Please include a brief description of the changes or features added]

  • added filter that find job's based on user preferences
  • update jobs data (json file)
  • added multiple types of jobs with experience

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

job type = contract
image

job type = part-time
image

job with experience of 2-6 years
image

jobs with experience of 1 years or 2 - 6 years with full time
image

also added search query
we try to search system Analyst with some filter
image

search jobs by their locations
here we try to find jobs of location West US
image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Please check this and merge it

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kaam-do ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 2:58pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhruv8433
Copy link
Contributor Author

@PatilHarshh

  • i added filter by job type and experience as well search with job title and location please check this out and merge it

@dhruv8433
Copy link
Contributor Author

@PatilHarshh

as a mentor, please response
i already create 4 5 pr and you don't even merge single
it's your responsibility to answer and give response

@PatilHarshh
Copy link
Owner

@PatilHarshh

as a mentor, please response i already create 4 5 pr and you don't even merge single it's your responsibility to answer and give response

Sorry ! @dhruv8433 Being Late Response ! Your Deployment giving errors , make sure your update your local repository and then push code

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented May 21, 2024

@PatilHarshh

check this out
image
there is no build error in my code

the error is already present in current build
image

see the deployment

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented May 21, 2024

@PatilHarshh the current build have errors that's why i got errors too in my deployment

@PatilHarshh
Copy link
Owner

did You updated your local repo ? command :: " npm pull "

@dhruv8433
Copy link
Contributor Author

@PatilHarshh

already up-to-date
image

@dhruv8433
Copy link
Contributor Author

@PatilHarshh now you can merge this

and also ensure there is no signle error as well conflict
image

@dhruv8433 dhruv8433 mentioned this pull request May 21, 2024
@dhruv8433
Copy link
Contributor Author

@PatilHarshh Please check this and response

@dhruv8433
Copy link
Contributor Author

@PatilHarshh Response !!!

@dhruv8433
Copy link
Contributor Author

@PatilHarshh ,
when userr click on find-job tab then display this page ,
user can able to filter job with location,job type and based on experiance:
this is navigation:
image

and this is /find-job route then display :
image

@PatilHarshh
Copy link
Owner

Great !! @dhruv8433

@PatilHarshh PatilHarshh merged commit 4441a15 into PatilHarshh:main May 25, 2024
2 checks passed
@PatilHarshh PatilHarshh mentioned this pull request May 25, 2024
@dhruv8433
Copy link
Contributor Author

dhruv8433 commented May 25, 2024

@PatilHarshh

also note that i already completed
#86 and #75

due to more than one pr it all merged in single #118

so please close this and this #118 i provided all functions of search and filter than why you added level 1...!!
you can check out

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

job type = contract
image

job type = part-time
image

job with experience of 2-6 years
image

jobs with experience of 1 years or 2 - 6 years with full time
image

also added search query
we try to search system Analyst with some filter
image

search jobs by their locations
here we try to find jobs of location West US
image

@PatilHarshh PatilHarshh added level2 and removed level1 labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Filter Not Working
2 participants