Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter shadow in DownloadCacheCleaner #318

Conversation

Matyrobbrt
Copy link
Member

During the 1.20.4 port both the in path parameter and the parameter of the anonymous class method in vacuumCacheDir were named path therefore leading to the outer variable being shadowed by the inner one.

During the 1.20.4 port both the in path parameter and the parameter of the anonymous class method in `vacuumCacheDir` were named `path` therefore leading to the outer variable being shadowed by the inner one.
@Matyrobbrt Matyrobbrt requested a review from a team as a code owner January 17, 2025 14:17
@sciwhiz12 sciwhiz12 added bug An error, misspell, incorrect information, or other issue mappings Changes to the mapping data 1.21.x For Minecraft 1.21.x labels Jan 18, 2025
Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making a validator for this kind of error is going to be painful, and possibly requires some rethinking of the design of our toolchain.

For now, hotfix!

@sciwhiz12 sciwhiz12 merged commit 039af68 into ParchmentMC:versions/1.21.x Jan 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.x For Minecraft 1.21.x bug An error, misspell, incorrect information, or other issue mappings Changes to the mapping data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants