Development

TODO: re-evaluate whether we need a GitHub App, or if some or all of our features can be an automation program running behind our machine user.

Specific to Parchment's PR review process. Should be generified and made configurable.

TODO: change from/supplement the 'ready to merge' label with a GH check run

Ignore Rules

• Ignore PRs that are closed or merged.
• Ignore PRs which do not have the mappings label.
• Ignore PRs which have the ready to merge label.

Regular PR Process

If the following conditions are true, then label the PR with the ready to merge label.

• PRs must have at least 2 approving reviews.
• One approving review must be from a member of the ParchmentMC/mapping-reviewers team.
• There are no reviews requesting changes from any reviewer with write access.
• There are no unresolved conversations.
• 48 hours (or if the minor changes label is applied, 24 hours) have passed since all of the following:
  • the second approving review;
  • the last approving review from a reviewer with write access which previously made a (not-dismissed) review requesting changes; and
  • the last resolved conversation.

Past this point be dragons! May or may not be implemented, just some musings

Invocations

The app may be invoked in a PR comment by writing a paragraph which begins with the phrase: Nitwit!. The rest of the paragraph will be interpreted as a command.

The commands may be interpreted based on a set of keywords from the full command, to allow paraphrasing and a certain degree of fault tolerance.

• Set a fixed-length discussion period of <duration>.

  Sets the PR to a fixed-length discussion period of the given duration. The duration must be a minimum of 2 days, and a maximum of 7 days, and the granularity will be to the hour. This must be invoked by a member of the ParchmentMC/mapping-reviewers team, and may not be invoked if a fixed-length discussion period is already active.

  If a fixed-length discussion period is already active, repository administrators may prepend the phrase Admin speaking: to forcefully set the new fixed-length discussion duration.

  Examples:

  • Nitwit! Set a fixed-length discussion period of 5 days.
  • Nitwit! Set a fixed-length discussion period of 3d12h.
  • Nitwit! Admin speaking: Set a fixed-length discussion of 80 hours.

• Extend the fixed-length discussion period by <duration>.

  Extends the PR's fixed-length discussion period by the given duration. The duration must be a maximum of 48 hours, and the granularity will be to the hour. This must be invoked by a member of the ParchmentMC/mapping-reviewers team, and may only be invoked if the current duration of the discussion is less than or equal to 72 hours, and the discussion has not yet been extended.

  Examples:

  • Nitwit! Extend a fixed-length discussion period by 24 hour.