Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved brigadier documentation #436

Merged
merged 43 commits into from
Oct 9, 2024
Merged

Conversation

Hinterhaeltiger
Copy link
Contributor

I improved the Command API's documentation. I moved everything to a new folder and added a page for arguments, so everything is clearer and you don't have to use the Fabric wiki for arguments :)

config/sidebar.paper.ts Show resolved Hide resolved
docs/versioned/paper/sidebars/1.20.json Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jun 26, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview 798a7d5

docusaurus.config.ts Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@Hinterhaeltiger Hinterhaeltiger marked this pull request as ready for review June 26, 2024 19:04
Copy link
Member

@olijeffers0n olijeffers0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, a few things left

docs/paper/dev/api/commands-api/arguments.mdx Outdated Show resolved Hide resolved
docs/paper/dev/api/commands-api/arguments.mdx Outdated Show resolved Hide resolved
docs/paper/dev/api/commands-api/arguments.mdx Outdated Show resolved Hide resolved
config/sidebar.paper.ts Show resolved Hide resolved
docs/paper/dev/api/commands-api/arguments.mdx Outdated Show resolved Hide resolved
docs/paper/dev/api/commands-api/arguments.mdx Outdated Show resolved Hide resolved
docs/paper/dev/api/commands-api/arguments.mdx Outdated Show resolved Hide resolved
docs/paper/dev/api/commands-api/arguments.mdx Outdated Show resolved Hide resolved
docs/paper/dev/api/commands-api/arguments.mdx Outdated Show resolved Hide resolved
Co-authored-by: Ollie <[email protected]>
@Hinterhaeltiger
Copy link
Contributor Author

Every suggestion should be resolved, if there's anything more, let me know :)

Co-authored-by: DerEchtePilz <[email protected]>
Copy link
Member

@olijeffers0n olijeffers0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these comments reviewed, looks good to merge

docs/paper/dev/api/command-api/arguments.mdx Outdated Show resolved Hide resolved
docs/paper/dev/api/command-api/arguments.mdx Outdated Show resolved Hide resolved
# Conflicts:
#	docs/paper/dev/api/command-api/commands.mdx
@olijeffers0n olijeffers0n merged commit f29ea4b into PaperMC:main Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants