Fix asyncCatcher on hardcrash shutdown #12035
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paper used to have a flag for AsyncCatcher called
enabled
, which would be toggled false when shutting the server down during a hard crash as seen here.The reason for this flag is without disabling the main thread checker, shutdown from a thread other than main will obviously fail due to the checks everywhere.
Paper's chunk changes broke this flags functionality, i.e it is set but never actually checked anywhere, this PR re-adds it being checked.
Fixes #12030