Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call HangingBreakByEntityEvent for collision with boats #10248

Closed
wants to merge 4 commits into from

Conversation

notTamion
Copy link
Contributor

@notTamion notTamion commented Feb 13, 2024

resolves #10058
post hardfork #11901
perhaps a getRemovers should be added since mulitple boats can be responsible for breaking an entity. let me know what you think

@notTamion notTamion requested a review from a team as a code owner February 13, 2024 12:55
@notTamion notTamion force-pushed the call-hangingbyentity branch from 686ba81 to 4ffa8d8 Compare February 15, 2024 12:01
@notTamion notTamion force-pushed the call-hangingbyentity branch 2 times, most recently from eed8bf0 to 998b5ec Compare April 28, 2024 12:35
@notTamion notTamion force-pushed the call-hangingbyentity branch from 998b5ec to e24405f Compare May 30, 2024 19:06
@notTamion notTamion force-pushed the call-hangingbyentity branch from e24405f to 56d2a37 Compare May 30, 2024 19:07
@notTamion
Copy link
Contributor Author

notTamion commented Nov 17, 2024

please don't approve unless you have actually tested the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Boats breaking hanging entities
7 participants