Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.0 #216

Merged
merged 19 commits into from
Dec 8, 2024
Merged

release 2.0 #216

merged 19 commits into from
Dec 8, 2024

Conversation

iosh
Copy link
Collaborator

@iosh iosh commented Dec 8, 2024

No description provided.

Copy link

changeset-bot bot commented Dec 8, 2024

🦋 Changeset detected

Latest commit: 8e68916

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nrm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iosh
Copy link
Collaborator Author

iosh commented Dec 8, 2024

@chouchouji Let us review again for this.

@chouchouji
Copy link
Contributor

image
It is strange.

@iosh
Copy link
Collaborator Author

iosh commented Dec 8, 2024

image It is strange.

Yes, i am checking.

@iosh
Copy link
Collaborator Author

iosh commented Dec 8, 2024

I have update the code and test, you can see there why the test is changed.
https://github.com/SBoudrias/Inquirer.js/blob/5713287885155c0081fca4190c17c18c598d9602/packages/select/src/index.ts#L212

@chouchouji
Copy link
Contributor

I have update the code and test, you can see there why the test is changed. https://github.com/SBoudrias/Inquirer.js/blob/5713287885155c0081fca4190c17c18c598d9602/packages/select/src/index.ts#L212

LGTM

@iosh iosh merged commit 0f076c5 into master Dec 8, 2024
4 checks passed
@chouchouji
Copy link
Contributor

I think we should update release ci.

@chouchouji
Copy link
Contributor

      - uses: pnpm/action-setup@v4
        with:
          version: 9

      - name: Setup Node.js 20.x
        uses: actions/setup-node@v4
        with:
          node-version: 20.x

      - name: Install Dependencies
        run: pnpm i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants