Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example in readme #212

Merged
merged 1 commit into from
Dec 4, 2024
Merged

docs: update example in readme #212

merged 1 commit into from
Dec 4, 2024

Conversation

chouchouji
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 184c98e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iosh
Copy link
Collaborator

iosh commented Dec 4, 2024

HI @chouchouji please add you to Contributors in readme.

@chouchouji
Copy link
Contributor Author

HI @chouchouji please add you to Contributors in readme.

image
like this?

@iosh
Copy link
Collaborator

iosh commented Dec 4, 2024

HI @chouchouji please add you to Contributors in readme.

image like this?

Yes.

@chouchouji
Copy link
Contributor Author

HI @chouchouji please add you to Contributors in readme.

image like this?

Yes.

Should we use this url https://contrib.rocks/image?repo=Pana/nrm in image? It should contain all of us.

image

@iosh
Copy link
Collaborator

iosh commented Dec 4, 2024

HI @chouchouji please add you to Contributors in readme.

image like this?

Yes.

Should we use this url https://contrib.rocks/image?repo=Pana/nrm in image? It should contain all of us.

image

ok to me.

@chouchouji
Copy link
Contributor Author

HI @chouchouji please add you to Contributors in readme.

image like this?

Yes.

Should we use this url https://contrib.rocks/image?repo=Pana/nrm in image? It should contain all of us.
image

ok to me.

Done. Please review. Thanks.

Copy link
Collaborator

@iosh iosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@iosh iosh merged commit c44f4f1 into Pana:master Dec 4, 2024
2 checks passed
@chouchouji chouchouji deleted the docs-readme branch December 4, 2024 06:02
@chouchouji
Copy link
Contributor Author

Hi, @iosh. I want to ask a question. Do we have this registry nodejitsu?

@iosh
Copy link
Collaborator

iosh commented Dec 4, 2024

Hi, @iosh. I want to ask a question. Do we have this registry nodejitsu?

No, I think we don't have this registry , we can remove it from readme.

@chouchouji
Copy link
Contributor Author

Hi, @iosh. I want to ask a question. Do we have this registry nodejitsu?

No, I think we don't have this registry , we can remove it from readme.

I optimize the readme in #213. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants