Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#108: Collaborator Edit Modal #195

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

JamesTLopez
Copy link
Contributor

@JamesTLopez JamesTLopez commented Feb 6, 2025

Summary

UI implementation of the Edit Modal with functional defaultValues and form validation.

Related Issues

Description of Changes

  • Add EditCollaboratorModal component
  • Added defaultValues/initialValues to InputBox component and TextAreaBox
  • refactor/organize translations
  • memoize modals
  • Apply validation to form in EditCollaboratorModal
  • Fixed improper zod field for suffix and middle name fields

Special Instructions

Theres is updates to the schema for collaborators so this requires a build.
Please run this in the top level folder

pnpm build:all

Readiness Checklist

  • Self Review
    • I have performed a self review of code
    • I have run the application locally and manually tested the feature
  • PR Format
    • The PR title is properly formatted to match the pattern: #{TicketNumber}: Description of Changes
    • Links are included to all relevant tickets
  • Labels Added
    • Label is added for each package/app that is modified (api, ui, data-model, etc.)
    • Label is added for the type of work done in this PR (feature, fix, chore, documentation)
  • Local Testing
    • Successfully built all packages locally
    • Successfully ran all test suites, all unit and integration tests pass
image
  • Updated Tests
    • Unit and integration tests have been added that describe the bug that was fixed or the features that were added
  • Documentation
    • All new environment variables added to .env.schema file and documented in the README
    • All changes to server HTTP endpoints have open-api documentation
    • All new functions exported from their module have TSDoc comment documentation

@JamesTLopez JamesTLopez marked this pull request as ready for review February 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant