Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP-VPC-Flow-logs-for-the-subnet-is-set-to-Off.json #117

Open
wants to merge 1 commit into
base: PCS-23.10.2
Choose a base branch
from

Conversation

jcallowaypanw
Copy link

Per KeyBank:

Justification:

Google documentation states that flow logging is not supported for GLOBAL_MANAGED_PROXY also.

Per Google documentation (Terraform Registry ):

Flow logging isn't supported if the subnet purpose field is set to subnetwork is REGIONAL_MANAGED_PROXY or GLOBAL_MANAGED_PROXY

Note that INTERNAL_LOAD_BALANCER is fine to keep in the RQL for backward compatibility, but it is no longer a valid value and was changed to REGIONAL_MANAGED_PROXY. See https://cloud.google.com/load-balancing/docs/proxy-only-subnets#migrate-purpose

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Per KeyBank:

Justification:

Google documentation states that flow logging is not supported for GLOBAL_MANAGED_PROXY also.

Per Google documentation (Terraform Registry ):

Flow logging isn't supported if the subnet purpose field is set to subnetwork is REGIONAL_MANAGED_PROXY or GLOBAL_MANAGED_PROXY

Note that INTERNAL_LOAD_BALANCER is fine to keep in the RQL for backward compatibility, but it is no longer a valid value and was changed to REGIONAL_MANAGED_PROXY. See https://cloud.google.com/load-balancing/docs/proxy-only-subnets#migrate-purpose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant