Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xcode formatter to danger #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add xcode formatter to danger #11

wants to merge 5 commits into from

Conversation

Palleas
Copy link
Owner

@Palleas Palleas commented Oct 27, 2017

No description provided.

Repository owner deleted a comment from Palleas-opensource Oct 28, 2017
@SPopenko
Copy link

@Palleas I believe you need the minor update for Danger file to let this PR passed danger check.
This line

%x( cat "#{OUTPUT}" | XCPRETTY_JSON_FILE_OUTPUT=xcodebuild_output.json bundle exec xcpretty -f "#{FORMATTER}" )

should be updated to this one:

%x( cat "#{OUTPUT}" | XCPRETTY_JSON_FILE_OUTPUT=xcodebuild_output.json bundle exec xcpretty -f `#{FORMATTER}` )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants