Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's a redundant UUID to string conversion happening in our NoSQLBaseDocument class. The
to_mongo
method performs UUID to string conversion even though this conversion is already handled by the overriddenmodel_dump
method.Current flow:
model_dump
converts all UUID values to stringsto_mongo
callsmodel_dump
to_mongo
then unnecessarily converts UUID values to strings againChanges:
to_mongo
Before:
After: