Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to SyncToAmrit API #44

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Updates to SyncToAmrit API #44

merged 2 commits into from
Jan 16, 2024

Conversation

kalyan-chokkam
Copy link

@kalyan-chokkam kalyan-chokkam commented Dec 14, 2023 •
edited
Loading

Description

Updates to sync to amrit (rmnch/syncDataToAmrit), to update benficiary data in i_beneficiarydetails table

Type of change

  • Bug fix
  • New feature
  • Enhancement
  • Refactoring
  • Documentation
  • Other ( please specify )

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@drtechie
Copy link
Member

LGTM.
@devikasuresh20, @ravishanigarapu can you please check if there is any impact on existing implementations?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ravishanigarapu
ravishanigarapu approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@ravishanigarapu ravishanigarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@ravishanigarapu ravishanigarapu merged commit 6a80e17 into PSMRI:develop Jan 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravishanigarapu ravishanigarapu ravishanigarapu approved these changes

@devikasuresh20 devikasuresh20 Awaiting requested review from devikasuresh20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalyan-chokkam @drtechie @ravishanigarapu