Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing conductance shape from Nt by 1 to Nt by 2 for ALL conductance models #2849

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

fixed simulating transport notebook so hardcoded gh is Nt by 2

e2ec2b0
Select commit
Loading
Failed to load commit list.
Open

Changing conductance shape from Nt by 1 to Nt by 2 for ALL conductance models #2849

fixed simulating transport notebook so hardcoded gh is Nt by 2
e2ec2b0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 27, 2023 in 1s

91.6% of diff hit (target 89.8%)

View this Pull Request on Codecov

91.6% of diff hit (target 89.8%)

Annotations

Check warning on line 86 in openpnm/algorithms/_advection_diffusion.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

openpnm/algorithms/_advection_diffusion.py#L86 

Added line #L86 was not covered by tests
View more details on Codecov