Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images #96

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Images #96

wants to merge 9 commits into from

Conversation

MattsAttack
Copy link
Contributor

Description

Implementation of image upload and display for post UI. Also fixes windows build.

Type of Change

  • ✨ New feature
  • 🐛 Bug fix

Checklist

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Fill out this template.
  • Log your hours.
  • Check that commits follow the Angular commit convention, more or less.
  • Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

  • Windows 11

@MattsAttack MattsAttack requested a review from a team as a code owner January 20, 2025 19:53
@MattsAttack
Copy link
Contributor Author

As of this commit, images are uploaded to the Appwrite bucket. Currently working on linking them to the post

Copy link

codecov bot commented Jan 20, 2025

Copy link
Member

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good so far! I think the main thing I'm noticing is that .cxx/ needs to get gitignored.

@lishaduck
Copy link
Member

@MattsAttack, syncing the IDs prevents multiple images from being attached. Do we want to support multiple images?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants