Skip to content

Commit

Permalink
GH Actions: use explicit PHPStan major
Browse files Browse the repository at this point in the history
This Monday, [PHPStan 2.0 will be released](https://phpc.social/@OndrejMirtes/113441109253809720).

I've done some preliminary scans with PHPStan 2.0-dev to check if this would have an impact on this codebase and as things are, this would mean the build would start to fail.

For now, I'm proposing to make a small change in the GH Actions workflow to explicitly use PHPStan 1.x.

This buys us some time to evaluate PHPStan 2.0 properly and to make any changes needed to make the codebase compatible with PHPStan 2.x when we're ready for it.

Note:
At least one of the new issues reported has been identified as a bug and reported to PHPStan: phpstan/phpstan#11980
  • Loading branch information
jrfnl committed Nov 9, 2024
1 parent de21892 commit bc5b3b3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/basics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ jobs:
phpstan:
name: "PHPStan"
uses: PHPCSStandards/.github/.github/workflows/reusable-phpstan.yml@main
with:
phpstanVersion: '1.x'

remark:
name: 'QA Markdown'
Expand Down

0 comments on commit bc5b3b3

Please sign in to comment.