Add Windows support for creating search adapters #452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try but now in the right repo :)
Description
Absolute paths on windows fail due to an undefined array key within the following line not having a scheme at all;
https://github.com/schranz-search/schranz-search/blob/d91446a972b7bcc894abfd803eff40fc7dd3c09c/packages/seal/src/Adapter/AdapterFactory.php#L140
This PR adds
Windows
support for the path resolution since$dsn
would fail later due to the secondparse_url
attempt returningfalse
again.In my case, the following
$dsn
would fail because it won't detect any scheme at all:loupe://C:\path\project\var\indexes
The early return is done before adding the fallback where it adds the adapter name with an `@´ :')
Unsure if we should go for the
PHP_OS_FAMILY
check and see if it's windows in this case 🤔?