Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for search multi Indexes by once (BC Break) #451

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Remove support for search multi Indexes by once (BC Break) #451

merged 5 commits into from
Oct 21, 2024

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Oct 21, 2024 •
edited
Loading

As discuss result of the current state in #99 we will not longer support search on multi indexes as most engine do not support that. See #99.

BC Breaks

  • The Engine::createSearchBuilder requires a parameter string $index
  • The Search returns not longer indexes instead of single index parameter
  • Elasticsearch and Opensearch can not longer search on multiple indexes in aggregated result

closes #99

@alexander-schranz alexander-schranz added the DX Improves the developer experience label Oct 21, 2024
@alexander-schranz alexander-schranz marked this pull request as ready for review October 21, 2024 17:28
This was referenced Oct 21, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-multi-index-support branch from 1fb0236 to c509c1d Compare October 21, 2024 20:14
@alexander-schranz alexander-schranz added Adapter: Opensearch Opensearch Adapter related issue Adapter: Memory Memory Adapter related issue Adapter: Meilisearch Meilisearch Adapter related issue SEAL Core Seal Core related issue Adapter: Algolia Algolia Adapter related issue Adapter: Solr Solr Adapter related issue Adapter: Typesense Typesense Adapter related issue Adapter: RediSearch RediSearch Adapter related issue Adapter: Loupe Loupe Adapter related issue Adapter: Elasticsearch Elasticsearch Adapter releated issue labels Oct 21, 2024
@alexander-schranz alexander-schranz merged commit d91446a into PHP-CMSIG:0.6 Oct 21, 2024
32 checks passed
@alexander-schranz alexander-schranz deleted the enhancement/remove-multi-index-support branch October 21, 2024 20:31
This was referenced Oct 21, 2024
Closed
Merged
alexander-schranz added a commit that referenced this pull request Oct 23, 2024
@alexander-schranz
Add docs about new SearchBuilder for single index (#453)
2feaf7c 
The docs was not yet update. See
#99 and
#451.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Adapter: Algolia Algolia Adapter related issue Adapter: Elasticsearch Elasticsearch Adapter releated issue Adapter: Loupe Loupe Adapter related issue Adapter: Meilisearch Meilisearch Adapter related issue Adapter: Memory Memory Adapter related issue Adapter: Opensearch Opensearch Adapter related issue Adapter: RediSearch RediSearch Adapter related issue Adapter: Solr Solr Adapter related issue Adapter: Typesense Typesense Adapter related issue DX Improves the developer experience SEAL Core Seal Core related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Search over multiple Indexes
1 participant
@alexander-schranz