-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NotInCondition
Filter
#448
Add NotInCondition
Filter
#448
Conversation
@alexander-schranz I'm not sure why some tests fail sometimes in CI. I have run the tests locally with docker for the following adapters: |
@ToshY there is currently an issue with the checkout process going on the false commit hash. You can retrigger the CI with additional commit push |
473768c
to
fd08574
Compare
I adopted the test case the order for none "searches" can be differently by the search engines so the testcase just need to check if the expected documents exists not if they are in the same order. This way also the other adapters seems to work fine. |
@ToshY all green 🎉 . Thank you for your contribution. |
This add supports for
NotInCondition
with the already support forAndCondition
andNotEqualCondition
it should be possible to implement aNotInCondition
in all adapters asNOT IN
is just a shortcut forNotEqualCondition
on the same fieldAND
connected.So instead of writing:
It should now be possible to write:
Fixes #445
Todo
NotInCondition