Skip to content

Commit

Permalink
Fix phpstan issues in spiral integration (#466)
Browse files Browse the repository at this point in the history
Not required to ignore in #465
  • Loading branch information
alexander-schranz authored Dec 27, 2024
1 parent 45c93e6 commit 7f4ae32
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/callable-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,28 @@ jobs:
- php-version: '8.3'
dependency-versions: 'highest'

- php-version: '8.4'
dependency-versions: 'highest'

steps:
- name: Wait for 5 seconds
run: sleep 5

- name: Output infos
run: |
echo "${{ github.event.pull_request.merge_commit_sha }}"
echo "${{ github.event.pull_request.head.sha }}"
- name: Checkout project
uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"

- name: Git infos
run: |
git rev-parse HEAD
git branch --show-current
- name: Start Docker services
if: ${{ inputs.docker }}
working-directory: ${{ inputs.directory }}
Expand Down
4 changes: 2 additions & 2 deletions integrations/spiral/src/Console/ReindexCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ public function __invoke(
EngineRegistry $engineRegistry,
): int {
/** @var \DateTimeImmutable|null $dateTimeBoundary */
$dateTimeBoundary = $this->datetimeBoundary ? new \DateTimeImmutable((string) $this->datetimeBoundary) : null; // @phpstan-ignore-line
$dateTimeBoundary = $this->datetimeBoundary ? new \DateTimeImmutable((string) $this->datetimeBoundary) : null;
/** @var array<string> $identifiers */
$identifiers = \array_filter(\explode(',', (string) $this->identifiers)); // @phpstan-ignore-line
$identifiers = \array_filter(\explode(',', (string) $this->identifiers));

$reindexConfig = ReindexConfig::create()
->withIndex($this->indexName)
Expand Down

0 comments on commit 7f4ae32

Please sign in to comment.