Skip to content

Commit

Permalink
Fix typos in AndCondition and OrCondition and Logo Creator, add hint …
Browse files Browse the repository at this point in the history
…about Algolia AndCondition (#443)

Thx to @ToshY, @jdreesen and @Toflar for the corrections and hints in
the documentation.

---------

Co-authored-by: ToshY <[email protected]>
Co-authored-by: Jacob Dreesen <[email protected]>
Co-authored-by: Yanick Witschi <[email protected]>
  • Loading branch information
4 people authored Oct 10, 2024
1 parent dea7d43 commit 663bc73
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/_templates/sidebar/brand.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

{% if logo_url or (theme_light_logo and theme_dark_logo) %}
<span class="sidebar-logo-creator centered">
<span>Logo created by</span> <a target="_blank" href="https://cargocollective.com/meinewilma">Mein Wilma</a>
<span>Logo created by</span> <a target="_blank" href="https://cargocollective.com/meinewilma">Meine Wilma</a>
</span>
{%- endif %}

Expand Down
14 changes: 10 additions & 4 deletions docs/search-and-filters/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ The field is required to be marked as ``filterable`` in the index configuration.
OrCondition
~~~~~~~~~~~

The ``OrCondition`` is used to filter by two or more conditions where at least one condition need to match.
The ``OrCondition`` is used to filter by two or more conditions where at least one condition needs to match.

.. code-block:: php
Expand All @@ -252,9 +252,9 @@ The fields are required to be marked as ``filterable`` in the index configuratio
AndCondition
~~~~~~~~~~~~

The ``AndCondition`` is used to combine two or multiple conditions where all conditions need to match.
As by default all conditions are ``AND``` connected it only make sense to use ``AndCondition`` in
combination with an ``OrCondition`` filters.
The ``AndCondition`` is used to combine two or more conditions where all conditions need to match.
By default, all conditions are connected with ``AND``, so it only makes sense to use an ``AndCondition``
in combination with ``OrCondition`` filters.

.. code-block:: php
Expand All @@ -275,6 +275,12 @@ combination with an ``OrCondition`` filters.
The fields are required to be marked as ``filterable`` in the index configuration.


.. note::

If the ``Algolia`` Adapter is used not all kind of combination with ``OrCondition`` are possible.
See `this Github Issue <https://github.com/algolia/algoliasearch-client-php/issues/385>`__ for more information.

Filter on Objects and Typed Fields
----------------------------------

Expand Down

0 comments on commit 663bc73

Please sign in to comment.