Fix filters invalidating players from other matches #1455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes the NPE of:
Also adds the match id to failures to run a ticking task, and gets rid of a
remove
that was never doing anything, as that Map has scope as key, not runnable (so it was doing nothing, no behavior change) and i don't think we should stop any tickable that throws an exception, as that can break pgm even more (ie: a single error checking filters means no more dynamic filters for the rest of the match)