-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor channels #1423
Merged
Merged
Refactor channels #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pugzy
force-pushed
the
rebased-channels
branch
from
November 6, 2024 01:21
816ef4e
to
51a6564
Compare
Pablete1234
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if ChannelManager should just be renamed to ChatManager too
core/src/main/java/tc/oc/pgm/channels/PrivateMessageChannel.java
Outdated
Show resolved
Hide resolved
calcastor
reviewed
Nov 7, 2024
Pablete1234
reviewed
Nov 7, 2024
core/src/main/java/tc/oc/pgm/channels/PrivateMessageChannel.java
Outdated
Show resolved
Hide resolved
Pablete1234
reviewed
Nov 7, 2024
Pugzy
force-pushed
the
rebased-channels
branch
from
November 20, 2024 22:39
99d22c6
to
d217b84
Compare
Signed-off-by: William Jeffcock <[email protected]> Signed-off-by: Pugzy <[email protected]>
Signed-off-by: Pugzy <[email protected]>
Signed-off-by: Pugzy <[email protected]>
Signed-off-by: Pugzy <[email protected]>
Signed-off-by: Pugzy <[email protected]>
Pugzy
force-pushed
the
rebased-channels
branch
from
November 20, 2024 23:35
d217b84
to
826dc99
Compare
Pablete1234
approved these changes
Nov 20, 2024
Pablete1234
pushed a commit
that referenced
this pull request
Nov 30, 2024
Signed-off-by: William Jeffcock <[email protected]> Signed-off-by: Pugzy <[email protected]> Co-authored-by: William Jeffcock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1306 updated to new cloudy framework