Update to Cloud 2.0 #1319
Merged
Update to Cloud 2.0 #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2024
Pablete1234
reviewed
May 21, 2024
core/src/main/java/tc/oc/pgm/command/parsers/MapPoolParser.java
Outdated
Show resolved
Hide resolved
Pablete1234
reviewed
May 21, 2024
Pablete1234
reviewed
May 21, 2024
Pablete1234
reviewed
May 21, 2024
core/src/main/java/tc/oc/pgm/command/parsers/VictoryConditionParser.java
Outdated
Show resolved
Hide resolved
Pablete1234
previously approved these changes
May 25, 2024
Pablete1234
added
ready
|
Let's hold off on merging this one purely to get other dependants ready |
calcastor
force-pushed
the
cloud-2.0
branch
2 times, most recently
from
972b9cd to
ff322a6
Compare
Co-authored-by: Pablo Herrera <[email protected]> Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: Pablo Herrera <[email protected]>
calcastor
force-pushed
the
cloud-2.0
branch
3 times, most recently
from
54ab962 to
79710c1
Compare
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Pablete1234
approved these changes
Jun 10, 2024
cswhite2000
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates PGM to Cloud 2.0
This PR does not include general cleanup to take advantage of Cloud 2.0 improvements and changes, and is essentially a director port to start.
We removed command confirmation because it was never used at all from the original port over to Cloud.