Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup minor map & default repo issues #1318

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

Pablete1234
Copy link
Member

Fixes a few minor issues with current map loading, especially when default configs are used for first-time PGM users:

  • Hardcoded default repo used default-maps while the config had a commented out maps-default, both of those now align
  • Improved logging around timing out while loading maps, which can happen if you configure a big git repo on a slow connection, or have loads of usernames to resolve first time
  • Fixed links to map xml in /map having incorrect paths if server runs on windows

@Pablete1234 Pablete1234 added the bug Something isn't working label May 12, 2024
@Pablete1234 Pablete1234 requested a review from Electroid as a code owner May 12, 2024 21:27
@Pablete1234 Pablete1234 force-pushed the cleanup-default-repo branch from 7f5bcb4 to 3cd8f41 Compare May 13, 2024 19:29
@Pablete1234 Pablete1234 added the ready PR is ready to merge label May 20, 2024
@Electroid Electroid merged commit 7a860ad into dev May 26, 2024
2 checks passed
@Electroid Electroid deleted the cleanup-default-repo branch May 26, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PR is ready to merge
Development

Successfully merging this pull request may close these issues.

4 participants