Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy tablist empty spots #1315

Merged
merged 1 commit into from
May 6, 2024
Merged

Fix legacy tablist empty spots #1315

merged 1 commit into from
May 6, 2024

Conversation

Pablete1234
Copy link
Member

Currently 1.7 tablist has some slots that never get updated. This is the result of internal changes in adventure, causing the strings having the same color code to serialize differently.

The scoreboard team player would be like this (notice the $0 is only once, instead of before each char):
image
While the name entries themselves are indeed repeated:
image

Note in this last picture, all the missing entries are the ones with colors right after another.

To fix this i've moved away from using adventure at all to create these deranged names, and instead went to handling plain old strings instead, hardcoding what i needed directly. Now all entries are 2 chars each (enough for up to 255 slots, since it's HEX), and

@Pablete1234 Pablete1234 added the bug Something isn't working label May 6, 2024
@Pablete1234 Pablete1234 requested a review from Electroid as a code owner May 6, 2024 22:44
@Pablete1234 Pablete1234 added the ready PR is ready to merge label May 6, 2024
Signed-off-by: Pablo Herrera <[email protected]>
@Pablete1234 Pablete1234 force-pushed the fix-legacy-tablist branch from fcbed33 to 39855d1 Compare May 6, 2024 22:55
@Electroid Electroid merged commit 85913f2 into dev May 6, 2024
2 checks passed
@Electroid Electroid deleted the fix-legacy-tablist branch May 6, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PR is ready to merge
Development

Successfully merging this pull request may close these issues.

2 participants