Improve world border logic #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Herrera <[email protected]>
Pablete1234
force-pushed
the
fix-worldborder-checks
branch
from
c82ffae to
9f20fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently worldborder checks are not lenient enough for odd-block sized borders, like if the border is at half the block, the vanilla client will let you walk the full block, but pgm will teleport you back. This makes borders very annoying as valid vanilla movements will cause setbacks.
Ontop of that, world borders in vanilla are actually composed of not just size and center, but also a max world size. This means the world borders can actually be rectangles, and therefore can't be checked with a simple
abs(x - center.x) < radius, as that just doesn't hold true. To add insult to injury, bukkit exposes none of this and pretends borders are always square, completely ignoring on the api-side the existance of max world size, which means in pgm you could fly right thru the max world size.To end, a funny rectangular world border:
