Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add hitTestBehavior to polylines #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: 🎸 add hitTestBehavior to polylines #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions lib/flutter_map_tappable_polyline.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,17 @@ class TappablePolylineLayer extends PolylineLayer {
/// The optional callback to call when no polyline was hit by the tap
final void Function(TapUpDetails tapPosition)? onMiss;

/// The hit test behavior of the polyline
final HitTestBehavior hitTestBehavior;

TappablePolylineLayer({
this.polylines = const [],
this.onTap,
this.onMiss,
this.pointerDistanceTolerance = 15,
super.polylineCulling = false,
super.key,
this.hitTestBehavior = HitTestBehavior.translucent,
});

@override
Expand Down Expand Up @@ -91,7 +95,21 @@ class TappablePolylineLayer extends PolylineLayer {
_zoomMap(details, context, mapState);
},
onTapUp: (TapUpDetails details) {
_forwardCallToMapOptions(details, context, mapState);
final hasTouchHitPolyline =
_handlePolylineTap(details, onTap, onMiss);

switch (hitTestBehavior) {
case HitTestBehavior.translucent:
_forwardCallToMapOptions(details, context, mapState);
break;
case HitTestBehavior.opaque:
break;
case HitTestBehavior.deferToChild:
if (!hasTouchHitPolyline) {
_forwardCallToMapOptions(details, context, mapState);
}
break;
}
_handlePolylineTap(details, onTap, onMiss);
},
child: Stack(
Expand All @@ -106,7 +124,7 @@ class TappablePolylineLayer extends PolylineLayer {
);
}

void _handlePolylineTap(
bool _handlePolylineTap(
TapUpDetails details, Function? onTap, Function? onMiss) {
// We might hit close to multiple polylines. We will therefore keep a reference to these in this map.
Map<double, List<TaggedPolyline>> candidates = {};
Expand Down Expand Up @@ -166,11 +184,15 @@ class TappablePolylineLayer extends PolylineLayer {
}
}

if (candidates.isEmpty) return onMiss?.call(details);
if (candidates.isEmpty) {
onMiss?.call(details);
return false;
}

// We look up in the map of distances to the tap, and choose the shortest one.
var closestToTapKey = candidates.keys.reduce(min);
onTap!(candidates[closestToTapKey], details);
return true;
}

void _forwardCallToMapOptions(
Expand Down