Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11189: DropdownServerSide, FloatingActions and BottomSheet #992

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

joselrio
Copy link
Contributor

This PR will fix some issues at DropdownServerSide, FloatingActions and BottomSheet patterns...

What was happening

DropdownServerSide

If Search Input gets typed text and an icon to clear the input is visible, once the clear input icon gets clicked it will close the Dropdown. This occurs only at phone devices.

FloatingActions

CSS selector issue that was preventing intend animation occurs.

BottomSheet

CSS invalid property usage.

What was done

DropdownServerSide

Once the click occurs logic was added to prevent the close.

FloatingActions

Fixed CSS selector.

BottomSheet

Fixed CSS selector.

Note:
This PR will also fix #989, and #990

@joselrio joselrio requested a review from a team as a code owner September 23, 2024 15:35
Copy link

@joselrio joselrio merged commit 559a53e into dev Sep 24, 2024
12 of 14 checks passed
@joselrio joselrio deleted the ROU-11189 branch September 24, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid property value - Floating actions
3 participants