Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11487: Fix event for when sidebar starts open #1007

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

rugoncalves
Copy link
Contributor

This PR is for fixing a misbehavior when the sidebar starts open.

What was happening

  • When the sidebar starts open
  • And has overlay (meaning, can be closed with click outside of it)
  • The events to intercept the click and close the sidebar were not being added:
    image
    (notice, the private method _openSidebar() is invoked by the method _setInitialCssClasses() within the method build())

What was done

  • The code that adds the event was removed from the if that checks if the sidebar is already built:
    image

Test Steps

  1. Go to test page
  2. Open the sidebar
  3. Click on the overlay

Screenshots

sidebar close issue

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@rugoncalves rugoncalves requested a review from a team as a code owner January 6, 2025 17:31
@rugoncalves rugoncalves merged commit 7fa2a5f into dev Jan 8, 2025
2 of 5 checks passed
@rugoncalves rugoncalves deleted the ROU-11487 branch January 8, 2025 10:55
Copy link

sonarqubecloud bot commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants