-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New variables #199
base: main
Are you sure you want to change the base?
New variables #199
Conversation
Welcome, new contributor! It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the
Please make sure you've read our contributing guide. |
@tlogan2000 Once the PR is ready, feel free to use your ultimate admin powers to merge while bypassing the license check. That check will always fail until I find a moment to split the offending modules out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will relook at a couple of things this pm in the end. I'm confused about something
…y-means" project to _transformation and _invert_sign
…into new-variables
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Added two new variables tos and sicons to .json
Does this PR introduce a breaking change?
No, test done
Other information: