-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NRCan Gridded support #172
base: fix_eccc
Are you sure you want to change the base?
Conversation
What do you think of calling it NRCANmet instead of NRCAN to fit with PCIC? more context: https://github.com/Ouranosinc/ouranos_data_catalog/pull/33) Also, it would be nice to add the version in the attrs. |
Je proposait camel case: NRCanMet
I have no confirmed information about that but I think they speak of it in terms of ANUSPLIN. |
I prefer NRCANmet (not camel case) as this is how it is written in a lot of places(https://www.nature.com/articles/sdata2018299, https://www.pacificclimate.org/data/daily-gridded-meteorological-datasets, https://scenarios-climatiques.canada.ca/?page=CanDCS6-notes, https://esd.copernicus.org/articles/11/301/2020/, https://www.mdpi.com/2073-4433/11/12/1363) |
# Conflicts: # src/miranda/convert/configs/nrcan-gridded-obs_cf_attrs.json
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No.
Other information:
FYI @juliettelavoie @vindelico