Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors and visuals for multiline track infos #311

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

bloodwiing
Copy link
Contributor

Related to issue #309

I also had track that would crash the UI, but this time the tracks had newlines in the titles, artist fields, etc.

I tried to find most of the places where the UI references the track name and replaced newlines with spaces.
The only thing I didn't check was the Lyrics screen, but when the track has no lyrics, the default text looks fine with the newlines, so I kept it as is.

Here is the before and after of changes
foobar2000_2024-08-23_18-34-17
foobar2000_2024-08-23_18-30-57

The control menu and title bar looked really goofy

Not exactly sure how unusual characters would cause issues here, but could also inspect if provided the audio file

@Ottodix Ottodix merged commit be0f989 into Ottodix:master Oct 19, 2024
@Ottodix
Copy link
Owner

Ottodix commented Oct 19, 2024

Hello,
Thanks for your proposal! It's now merged to the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants