Deploy 108 - Upgrade OETH Vault

[shahthepro]

Code change PRs

• Make withdrawalClaimDelay a variable
  • Enable async withdrawals on superOETHb #2275
• Allow guardian/governor to redeem instantly without fees
  • Allow guardian to redeem instantly without fees #2380
• NOTE: Doesn't upgrade OETH token since it has already been upgraded with deployment 116
  • Deploy 116 - Upgrade OETH with Yield Forwarding. #2374

Deployment

Contract	Address
OETHVaultCore	0x46b380E07dA15B631C1FB7AB387cC35169bF359a
OETHVaultAdmin	0x2Fe2Fc22c5874D60a006351F4c5c5701D476B4fD

Governance

• Proposal: 65756708910242452493001228142964504430010766487241550114316648937729891405136
• Propose Tx

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] The storage slots of the deployed contracts align and there're no conflicts
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.94%. Comparing base (1b78421) to head (aa19735).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2381      +/-   ##
==========================================
- Coverage   51.00%   50.94%   -0.07%     
==========================================
  Files          92       92              
  Lines        4515     4515              
  Branches     1198     1198              
==========================================
- Hits         2303     2300       -3     
- Misses       2209     2211       +2     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[naddison36]

• All deployed contracts are listed in the deploy PR's description
• Deployed contract's verified code (and all dependencies) match the code in master
• Contract constructors have correct arguments
• The transactions that interacted with the newly deployed contract match the deploy script.
• The storage slots of the deployed contracts align and there're no conflicts
• Governance proposal matches the deploy script
• Smoke tests pass after fork test execution of the governance proposal

sol2uml diff 0x46b380E07dA15B631C1FB7AB387cC35169bF359a .,node_modules
Compared the "OETHVaultCore" contract with address 0x46b380E07dA15B631C1FB7AB387cC35169bF359a on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IDripper.sol
match   contracts/interfaces/IGetExchangeRateToken.sol
match   contracts/interfaces/IOracle.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/OETHVaultCore.sol
match   contracts/vault/VaultCore.sol
match   contracts/vault/VaultInitializer.sol
match   contracts/vault/VaultStorage.sol

sol2uml diff 0x2Fe2Fc22c5874D60a006351F4c5c5701D476B4fD .,node_modules
Compared the "OETHVaultAdmin" contract with address 0x2Fe2Fc22c5874D60a006351F4c5c5701D476B4fD on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IOracle.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/ISwapper.sol
match   contracts/interfaces/IVault.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/OETHVaultAdmin.sol
match   contracts/vault/VaultAdmin.sol
match   contracts/vault/VaultStorage.sol

Storage slots of old VaultCore contract

sol2uml storage 0x49b60053869a0a7ef60242ea7a4d1317a8d51f54 --hideExpand __gap,______gap,_deprecated_swapTokens -o OETHVaultCoreOld.svg

Storage slots of new VaultCore contract

sol2uml storage 0x46b380E07dA15B631C1FB7AB387cC35169bF359a --hideExpand __gap,______gap,_deprecated_swapTokens -o OETHVaultCoreNew.svg

[naddison36]

I've verified the deployment

[clement-ux]

• All deployed contracts are listed in the deploy PR's description
  • OETHVaultCore
  • OETHVaultAdmin
• Deployed contract's verified code (and all dependencies) match the code in master
• Contract constructors have correct arguments
  • OETHVaultCore
    • WETH
  • OETHVaultAdmin
    • WETH
• The transactions that interacted with the newly deployed contract match the deploy script.
  • No interaction outside from governance.
• The storage slots of the deployed contracts align and there're no conflicts
  • OETHVaultCore
  • OETHVaultAdmin
• Governance proposal matches the deploy script
  • call upgradeTo() on vaultProxy with deployed OETHVaultCore address.
  • call setAdminImpl() on vault with deployed OETHVaultAdmin address.
  • call setWithdrawalClaimDelay() on vault with 10 mins (258 in hexa).
• Smoke tests pass after fork test execution of the governance proposal

Deployed contract's verified code

• OETHVaultCore

sol2uml diff 0x46b380E07dA15B631C1FB7AB387cC35169bF359a .,node_modules
(node:13206) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "OETHVaultCore" contract with address 0x46b380E07dA15B631C1FB7AB387cC35169bF359a on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IDripper.sol
match   contracts/interfaces/IGetExchangeRateToken.sol
match   contracts/interfaces/IOracle.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/OETHVaultCore.sol
match   contracts/vault/VaultCore.sol
match   contracts/vault/VaultInitializer.sol
match   contracts/vault/VaultStorage.sol

• OETHVaultAdmin

sol2uml diff 0x2Fe2Fc22c5874D60a006351F4c5c5701D476B4fD .,node_modules

(node:13261) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "OETHVaultAdmin" contract with address 0x2Fe2Fc22c5874D60a006351F4c5c5701D476B4fD on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IOracle.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/ISwapper.sol
match   contracts/interfaces/IVault.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/OETHVaultAdmin.sol
match   contracts/vault/VaultAdmin.sol
match   contracts/vault/VaultStorage.sol