Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Harvester V2 for SSV strategies. #2363

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

clement-ux
Copy link
Contributor

@clement-ux clement-ux commented Jan 23, 2025

Contracts

  • Upgrade OETH simple harvester to transfer WETH directly to FixedRateDripper instead of strategist.

Governance

  1. Deploy new simple Harvester.
  2. Change harvester on all SSV strategies.
  3. Support strategies on the harvester.
  4. Sending all WETH from the OldDripper to FixedRateDripper.

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Copy link

github-actions bot commented Jan 23, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against b7e3923

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.07%. Comparing base (477e67e) to head (b7e3923).

Files with missing lines Patch % Lines
...ontracts/contracts/harvest/OETHHarvesterSimple.sol 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2363      +/-   ##
==========================================
+ Coverage   51.54%   52.07%   +0.53%     
==========================================
  Files          91       91              
  Lines        4414     4426      +12     
  Branches     1162     1166       +4     
==========================================
+ Hits         2275     2305      +30     
+ Misses       2136     2118      -18     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clement-ux clement-ux marked this pull request as ready for review January 24, 2025 06:53
shahthepro
shahthepro previously approved these changes Jan 24, 2025
@clement-ux clement-ux requested a review from naddison36 January 24, 2025 09:41
shahthepro
shahthepro previously approved these changes Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants