Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment script for multichain strategist #2356

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shahthepro
Copy link
Collaborator

@shahthepro shahthepro commented Jan 16, 2025

Overview

  • Updates our contracts to use multi-chain guardian (replacing our old 2/8 on mainnet)
  • All our strategy contracts use the Vault to read the strategistAddr, so no update is needed there
  • Have intentionally skipped updating a few contracts like AuraWETHPriceFeed since they are no longer in use by any of our other contracts

Governance Proposal

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.09%. Comparing base (82baad3) to head (a38182d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2356   +/-   ##
=======================================
  Coverage   53.09%   53.09%           
=======================================
  Files          82       82           
  Lines        4196     4196           
  Branches     1101     1101           
=======================================
  Hits         2228     2228           
  Misses       1965     1965           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahthepro shahthepro marked this pull request as ready for review January 16, 2025 12:10
clement-ux
clement-ux previously approved these changes Jan 16, 2025
Copy link
Contributor

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@DanielVF
Copy link
Collaborator

image

Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the actions in the proposal are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants