Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy a Fixed Rate Dripper for OETH. #2350

Closed
wants to merge 8 commits into from

Conversation

clement-ux
Copy link
Contributor

@clement-ux clement-ux commented Jan 13, 2025

This PR aims to:

  • Add a new function to the current Dripper.sol contract, that allows the governor to transfer all tokens sitting in the Dripper to a specified address.
  • Deploy this new implementation and upgrade the current Dripper contract on OETH.
  • Deploy a new proxy + implementation for a Fixed Rate Dripper (no new code).
  • Transfer all remaining WETH from the current Dripper to the new one.
  • Set the new dripper address on the vault.

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Copy link

github-actions bot commented Jan 13, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against d6e4165

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.28%. Comparing base (c77fe36) to head (d6e4165).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2350      +/-   ##
==========================================
- Coverage   53.62%   53.28%   -0.34%     
==========================================
  Files          82       83       +1     
  Lines        4196     4200       +4     
  Branches     1101     1102       +1     
==========================================
- Hits         2250     2238      -12     
- Misses       1943     1959      +16     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clement-ux clement-ux marked this pull request as ready for review January 14, 2025 14:59
@clement-ux
Copy link
Contributor Author

Closed as duplicated with deployment PR: #2351

@clement-ux clement-ux closed this Jan 16, 2025
@clement-ux clement-ux deleted the clement/fixed-rate-dripper-upgrade branch January 16, 2025 12:04
@sparrowDom sparrowDom restored the clement/fixed-rate-dripper-upgrade branch January 16, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants